chore: Fix unexpected connection-pool shut-down - #1095
Open
newtork wants to merge 24 commits into
Open
Conversation
newtork
marked this pull request as draft
February 11, 2026 16:10
CharlesDuboisSAP
marked this pull request as ready for review
August 4, 2026 12:50
CharlesDuboisSAP
added
please merge
CharlesDuboisSAP
changed the title
Jonas-Isr
reviewed
Aug 4, 2026
Comment on lines
+584
to
+587
| customHeaderProviders | ||
| .forEach( | ||
| provider -> builder | ||
| .append(provider, that.customHeaderProviders.get(customHeaderProviders.indexOf(provider)))); |
Member
There was a problem hiding this comment.
(Question)
Isn't this just equals to the following?
for (int i = 0; i < customHeaderProviders.size(); i++) {
builder.append(customHeaderProviders.get(i), that.customHeaderProviders.get(i));
}| return false; | ||
| } | ||
|
|
||
| val builder = |
Member
There was a problem hiding this comment.
(Very Minor)
To stay consistent.
Suggested change
| val builder = | |
| final var builder = |
| .append(resolveKeyStoreHashCode(keyStoreSupplier.get().getOrNull())) | ||
| .append(resolveKeyStoreHashCode(trustStore)) | ||
| .toHashCode(); | ||
| val builder = |
Member
There was a problem hiding this comment.
(Very Minor)
To stay consistent.
Suggested change
| val builder = | |
| final var builder = |
|
|
||
| @Test | ||
| //This is a known limitation of excluding header providers in the equality check of destinations | ||
| void testGetClientReturnsSameClientForDestinationsWithOnlyDifferentHeaderProviders() |
Member
There was a problem hiding this comment.
(Question)
Why is this test still green? Shouldn't it fail given the comment?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Related
I was wondering whether the following rule always holds true...?
I thought that would be correct, until I realized there's one exception in
HttpClientWrapper.The following method creates a new
HttpClientand inherits the connection-pool implicitly:cloud-sdk-java/cloudplatform/connectivity-apache-httpclient4/src/main/java/com/sap/cloud/sdk/cloudplatform/connectivity/HttpClientWrapper.java
Lines 94 to 107 in 5b1c7fe
I'm able to reproduce the reported bug.
That even can explain the observed behavior from garbage collector.
Definition of Done
Error handling created / updated & covered by the tests aboveDocumentation updatedRelease notes updated